This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($animate): clear the GCS cache even when no animation is detected #9382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the 1.2 commit: https://github.com/matsko/angular.js/tree/pr_8813_1_2 |
|
sorry, I reviewed this yesterday but forgot to comment. the test looks good to me, but to be honest the source change looks right, but I can't tell for sure if it doesn't have other side effects. can you improve the comments you left on github and move them to the actual code? otherwise lgtm I guess ;-) |
$animate will cache subsequent calls to GCS in the event that the element with the same CSS classes and the same parentNode is being animated. Once the animation is started then $animate waits for one rAF before flushing the GCS lookup cache. Prior to this fix, if GCS was unable to detect any transitions or keyframes on the element then it would simply close the animation, but it would not trigger the rAF code to flush the cache. This issue caused a bug which made it difficult to detect why certain animations are not allowed to fire if the element didn't contain any CSS-based animations beforehand. Closes angular#8813
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$animate aims to speed up redundant calls to getComputedStyle to prevent
unessarry reflows in the event that similar elements are being animated
at the same time. A hidden bug was causing the GCS cache not to be reset
if an CSS-based animation was not found. This patch ensures that the
GCS lookup cache is always cleared after one animation reflow has
passed.
Closes #8813