Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Bugfix: Date-filter should support high-precision date-times #989

Closed

Conversation

steinjak
Copy link
Contributor

Hi,

We're using angular.js in a .net project, leveraging json.net as our server-side json serializer. This library outputs datetimes with more than three digits of precision in the millisecond part, and these strings are not recognized by the date filter. The enclosed fix (with test) updates the regular expression for ISO format dates to recognize 1-* rather than exactly 3 digits for milliseconds (according to wikipedia, "There is no limit on the number of decimal places for the decimal fraction"; I won't cash out $105 to check with the standard myself ;-)).

As always, let us know if we can improve this patch and resubmit.

All the best,

Stein Jakob Nordbø

@vojtajina
Copy link
Contributor

Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement).

CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form):
http://code.google.com/legal/individual-cla-v1.0.html

For corporations (print, sign and scan+email, fax or mail):
http://code.google.com/legal/corporate-cla-v1.0.html

@steinjak
Copy link
Contributor Author

steinjak commented Jun 6, 2012

Just signed your CLA :)

@andyneville
Copy link

Are there any updates on getting this pull request merged? We're experiencing the same problem, would love to have this fix merged into master

@mhevery
Copy link
Contributor

mhevery commented Aug 31, 2012

merged to NEXT

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants