Skip to content

Feat: ng add angularfire2 #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danielsogl opened this issue May 21, 2018 · 7 comments
Closed

Feat: ng add angularfire2 #1676

danielsogl opened this issue May 21, 2018 · 7 comments

Comments

@danielsogl
Copy link
Contributor

If not already in pipeline it would be great to be able to add the angularfire 2 package by a simple ng add angularfire2.

@codediodeio
Copy link
Contributor

codediodeio commented May 31, 2018

I've been working with schematics for AF2 and have the following proposals. Please post ideas and feedback so we can get the ball rolling:


ng add angularfire2/schematics
  • Updates the NgModule with imports, initializeApp, and credentials
  • Installs packages

ng generate component --firestore --auth
  • Generates a component with Firestore and AfAuth injected + some starter code
  • Mocks firebase in the component spec

ng generate module --template <crud|login|forms> 

Generates a fully fleshed-out feature module based on a goal like CRUD, user auth, forms, etc. The idea is here is to provide a best practices example to be used as a starting point or just solve common problems. (This will be the most difficult schemtic to build and maintain)

@markgoho
Copy link
Contributor

Has this gone anywhere?

@sulco
Copy link
Contributor

sulco commented Jul 30, 2018

Hey @codediodeio , I think it would be great to start even (or: especially) with having ng add angularfire2 command available that would

  • install the module
  • prepare configuration object to be filled
  • and setup the module

If you're opened to it, I would gladly help with this one (I've already prepared analogous part on other projects)

@codediodeio
Copy link
Contributor

@sulco That would be amazing. I've not had the time recently to move this forward. Just having ng add would be a valuable addition.

@sulco
Copy link
Contributor

sulco commented Jul 30, 2018

Great, I'm on it then - should have a PR within the next couple of days.

@sis0k0
Copy link

sis0k0 commented Aug 18, 2018

Heya, @sulco any updates on this? I can help if you have any problems :)

@williamJmelton
Copy link

@sulco I'm also willing to help out with this if needed.

sulco added a commit to sulco/angularfire2 that referenced this issue Sep 2, 2018
A possibility to install and configure the package with `ng add angularfire2` command

closes angular#1676
sulco added a commit to sulco/angularfire2 that referenced this issue Sep 3, 2018
A possibility to install and configure the package with `ng add angularfire2` command

closes angular#1676
sulco added a commit to sulco/angularfire2 that referenced this issue Sep 9, 2018
A possibility to install and configure the package with `ng add angularfire2` command

closes angular#1676
sulco added a commit to sulco/angularfire2 that referenced this issue Sep 9, 2018
A possibility to install and configure the package with `ng add angularfire2` command

closes angular#1676
sulco added a commit to sulco/angularfire2 that referenced this issue Mar 31, 2019
A possibility to install and configure the package with `ng add angularfire2` command

closes angular#1676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants