Skip to content

7.x has peer dependency on rxjs@~6.6.0 #2980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lucrus73 opened this issue Sep 25, 2021 · 2 comments · Fixed by #2998
Closed

7.x has peer dependency on rxjs@~6.6.0 #2980

lucrus73 opened this issue Sep 25, 2021 · 2 comments · Fixed by #2998

Comments

@lucrus73
Copy link

I need both @angular/fire@^7.1.0-rc4 and rxjs@^7.x in my Angular 12 project. yarn upgrade tells me:

warning " > @angular/[email protected]" has incorrect peer dependency "rxjs@~6.6.0"

Would it be possible to add @angular/fire peer dep on rxjs@^7.x as an alternative to rxjs@~6.6.0?
@google-oss-bot
Copy link

This issue does not seem to follow the issue template. Make sure you provide all the required information.

@jamesdaniels
Copy link
Member

We can probably safely mark ~6.6.0 || ^7.0.0 at this point. Let me investigate and insure compat/ is compatible.

@jamesdaniels jamesdaniels mentioned this issue Oct 7, 2021
Merged
jamesdaniels added a commit that referenced this issue Oct 7, 2021
@jamesdaniels
chore(deps): More tests & mark rxjs 7 peer (#2998)
c0df294 
* Mark rxjs 7 peer
* Flush out the matrix tests
* Add canary tests

Fixes #2980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More tests & mark rxjs 7 peer angular/angularfire
3 participants
@jamesdaniels @lucrus73 @google-oss-bot