refactor(db): WIP new database API #1156
Conversation
src/database/list/loaded.ts
Outdated
| import 'rxjs/add/operator/skipWhile'; | ||
| import 'rxjs/add/operator/withLatestFrom'; | ||
| import 'rxjs/add/operator/do'; | ||
| import 'rxjs/add/operator/filter'; |
There was a problem hiding this comment.
Consider refactoring these to call style?
such as mentioned here https://github.com/angular/material2/blob/c564df61f48ff9c40eea237c394a15adac19cfdb/CODING_STANDARDS.md#rxjs
There was a problem hiding this comment.
Yep! Totally on the //TODO: FIX THIS list. Wanted to get the POC up and running first.
There was a problem hiding this comment.
Comments are always welcome :)
src/database/observable/fromRef.ts
Outdated
| .map((combined: SnapshotPrevKey) => { | ||
| const {snapshot, prevKey} = combined; | ||
| return { event, snapshot, prevKey } | ||
| }).delay(0); |
There was a problem hiding this comment.
Whats up with this delay?
Looks like you're trying to ensure that it's at the end of the event loop?
There was a problem hiding this comment.
Yep! This is really for operations that happen with disconnected connections or when data exists in the cache. They can sometimes happen synchronously, which is an unfortunate quirk of the SDK.
There was a problem hiding this comment.
Gotcha, sounds legit. Maybe a small comment noting that?
See #1158 for details. If you have comments about the API please direct your feedback to that issue to keep the discussion in one place. However, if you have questions or improvements for the code please place them here.