Skip to content

Chrome headless & yarn for testing #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 23, 2018
Merged

Chrome headless & yarn for testing #1437

merged 7 commits into from
Jan 23, 2018

Conversation

jamesdaniels
Copy link
Member

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, npm install, npm run build, and npm test run successfully? (yes/no; required)

Description

  • Attempting to go with ChromeHeadless for karma tests
  • Seeing if going back to yarn for Travis works
  • Only build PRs once
  • Adding a sleep, seems to help some of the flakiness

Code sample

* Attempting to go with ChromeHeadless for karma tests
* Seeing if going back to `yarn` for Travis works
* Only build PRs once
@jamesdaniels jamesdaniels merged commit 9d2cd2e into master Jan 23, 2018
@jamesdaniels jamesdaniels deleted the chromeheadless branch January 23, 2018 20:24
myspivey pushed a commit to myspivey/angularfire2 that referenced this pull request Apr 10, 2018
* Using headless Chrome for karma tests, `--no-sandbox` needed on Travis
* Going back to using `yarn`
* Only build PRs once
* Pruning the `.travis.yml`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants