feat(firestore): allow collection and doc from ref#1487
Merged
davideast merged 1 commit intoangular:masterfrom Mar 7, 2018
Merged
feat(firestore): allow collection and doc from ref#1487davideast merged 1 commit intoangular:masterfrom
davideast merged 1 commit intoangular:masterfrom
Conversation
Allows firestore collection and doc to be constructed from both references and string paths. Fixes angular#1337
Collaborator
|
YES! @Maistho THANK YOU SO MUCH! Give me a bit and I'll give this a proper review. |
Collaborator
|
LOOKS PERFECT! Thank you so much @Maistho! |
Contributor
Author
|
Sweet! |
myspivey
pushed a commit
to myspivey/angularfire2
that referenced
this pull request
Apr 10, 2018
Allows firestore collection and doc to be constructed from both references and string paths. Fixes angular#1337
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? yesDescription
Allows firestore collection and doc to be constructed from both references and string paths.
Do I need to add better tests? I was not sure how to get a reference easily, so I just took one from
afs, which seems a bit backwards in a way.Also not sure if there are any required documentation changes. Let me know in that case!
Code sample
Changes the interfaces to: