Adding a test matrix and using the lockfile #1536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IgorMinar we can't review / merge on our own anymore. Adding you as reviewer in the meantime. |
davideast
approved these changes
Mar 30, 2018
myspivey
pushed a commit
to myspivey/angularfire2
that referenced
this pull request
Apr 10, 2018
* Adding a test matrix and using the lockfile * PRs dont upgrade, all test canary but allow failure * Fix the test * Whoops, yarn add now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests on PRs are red right now, becuase Firebase JS SDK is breaking. Fix how were testing.
A) if it's a PR, use the lockfile
B) if it's master, upgrade (this is so we're alerted of failure on Cron every night)
C) add a canary test, which is allowed to fail. I will work with the JS SDK team to make sure they're alerted of these failures
firebase/firebase-js-sdk#605