Skip to content

chore(): 5.0.0-rc.9 #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davideast merged 6 commits into from
May 17, 2018
Merged

chore(): 5.0.0-rc.9 #1660

davideast merged 6 commits into from
May 17, 2018

Conversation

@jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented May 16, 2018

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

@jamesdaniels jamesdaniels requested a review from davideast May 16, 2018 15:41
@jamesdaniels jamesdaniels requested a review from katowulf May 16, 2018 16:08
davideast
davideast approved these changes May 17, 2018
View reviewed changes
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davideast davideast merged commit bb1938f into master May 17, 2018
@davideast davideast deleted the rc9 branch May 17, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davideast davideast davideast approved these changes

@katowulf katowulf Awaiting requested review from katowulf

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamesdaniels @davideast @googlebot