Skip to content

chore(): release @angular/fire 5.0 🎉🔥🕺 #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 6, 2018
Merged

chore(): release @angular/fire 5.0 🎉🔥🕺 #1854

merged 10 commits into from
Sep 6, 2018

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Sep 4, 2018 •
edited
Loading

It's happening!

@davideast davideast self-requested a review September 4, 2018 18:23
davideast
davideast approved these changes Sep 4, 2018
View reviewed changes
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesdaniels
Copy link
Member Author

jamesdaniels commented Sep 4, 2018 •
edited
Loading

FYI angular-fire-5.0.0.tgz; going to toss this into my test projects and give it a whirl.

@jamesdaniels jamesdaniels changed the title Using @angular/fire Release @angular/fire 5.0! Sep 4, 2018
@jamesdaniels jamesdaniels changed the title Release @angular/fire 5.0! Release @angular/fire 5.0 🎉🔥🕺 Sep 4, 2018
@jamesdaniels jamesdaniels changed the title Release @angular/fire 5.0 🎉🔥🕺 chore(): release @angular/fire 5.0 🎉🔥🕺 Sep 4, 2018
@itsthesteve
Copy link

So happy to see it come under the @angular scope!!

@EdricChan03
Copy link
Contributor

So will the angularfire2 package be marked as deprecated?

This can be a breaking change for old projects that still rely on this (soon to be) old package.

@davideast
Copy link
Collaborator

@Chan4077 We will do a final release of 5.0.0 for the angularfire2 package. However, we will mark it as deprecated and move folks over to @angular/fire. Do you have any other ideas to help ease the move?

@EdricChan03
Copy link
Contributor

EdricChan03 commented Sep 5, 2018 •
edited
Loading

Schematics maybe?

EDIT: Maybe an upgrade schematic in the 5.0.0 release that makes consumers use @angular/fire instead?

@davideast
Copy link
Collaborator

@Chan4077 That's a fantastic idea

@jamesdaniels jamesdaniels merged commit 91ec37e into master Sep 6, 2018
@jamesdaniels jamesdaniels deleted the package_changes branch September 6, 2018 22:58
@EdricChan03
Copy link
Contributor

EdricChan03 commented Sep 7, 2018 •
edited
Loading

@davideast Will the angularfire2 package be marked as deprecated?

And will this repository be renamed to 🔥?

P.S. I don't literally mean rename this repository to a fire emoji. 😆

@davideast
Copy link
Collaborator

@Chan4077 Yes it will be! And why not an emoji 😂? Just kidding! We will likely do a rename soon for the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarunint sarunint sarunint left review comments

@davideast davideast davideast approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jamesdaniels @itsthesteve @EdricChan03 @davideast @sarunint @googlebot