-
Notifications
You must be signed in to change notification settings - Fork 2.2k
5.1 release: support Firebase 5.5, multi-tab sync, function region selection, and Angular 7 #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/firestore/firestore.module.ts
Outdated
@@ -10,11 +11,12 @@ export class AngularFirestoreModule { | |||
/** | |||
* Attempt to enable persistent storage, if possible | |||
*/ | |||
static enablePersistence(): ModuleWithProviders { | |||
static enablePersistence(persistenceSettings?: firestore.PersistenceSettings): ModuleWithProviders { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use PersistenceSettings
from ./interface
Waiting for this |
@@ -82,7 +83,7 @@ | |||
"systemjs": "^0.19.16", | |||
"systemjs-builder": "^0.15.7", | |||
"traceur": "0.0.96", | |||
"typescript": ">=2.7.2 <2.8.0" | |||
"typescript": ">=2.7.2 <2.8.0, >=3.1.1 <3.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there problems with supporting TypeScript 2.8.0, 2.9.2, 3.0.0,, 3.1.0 etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist
yarn install
,yarn test
run successfully? yesDescription
enablePersistence
factory method or via thePersistenceSettingsToken
injection token.firebase/app
is less broken, pull in many of the types from there.FunctionsRegionToken
Injection TokenCode sample