refactor(analytics): Add warning in the code#2610
Merged
jamesdaniels merged 2 commits intoangular:masterfrom Oct 26, 2020
Merged
refactor(analytics): Add warning in the code#2610jamesdaniels merged 2 commits intoangular:masterfrom
jamesdaniels merged 2 commits intoangular:masterfrom
Conversation
Adding a warning in the code so no one can turn the gtag function into an arrow function. PR angular#2594
Splaktar
reviewed
Oct 7, 2020
Contributor
Splaktar
left a comment
Splaktar
left a comment
There was a problem hiding this comment.
Thank you very much for sending this PR! I made a few suggestions to fine tune the comments, but I really appreciate you making the first draft here and getting this documented.
Applying changes suggested by other contributors
Contributor
Author
|
Thanks, I made the changes. Sorry for my bad English |
Splaktar
approved these changes
Oct 8, 2020
Contributor
Splaktar
left a comment
Splaktar
left a comment
There was a problem hiding this comment.
Thank you for making those updates! LGTM
jamesdaniels
approved these changes
Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a warning in the code so no one can turn the gtag function into an arrow function.
PR #2594
yarn install,yarn testrun successfully? yesDescription
As requested in the other PR by @Splaktar I inserted a warning in the code to alert anyone who is going to make changes in analytics about not turning the function into an arrow function