feat: update AngularFire to be compatible with Firebase JS SDK v8 #2620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: AngularFire now requires `firebase@^8.0.0`
sarunint
commented
Oct 27, 2020
| @@ -82,7 +82,7 @@ | |||
| "@types/gzip-size": "^5.1.1", | |||
| "@types/inquirer": "^0.0.44", | |||
| "@types/jasmine": "^3.3.13", | |||
| "@types/node": "^12.6.2", | |||
| "@types/node": "^12.6.2 < 12.12.42", | |||
There was a problem hiding this comment.
This is needed because DefinitelyTyped/DefinitelyTyped#44700, which is published to @types/[email protected]. Zone.js v0.10.2 has a type definition of global that is different to the @types/node one. The fix for Zone.js has already been merge (angular/angular#37861), but waiting for 0.11.3 release cut. (angular/angular#39440)
I've also tried upgrade Zone.js to 0.11.2 (latest at the time of writing), I've got 2 test failures. So we might need to fix the broken code to be compatible with the new Zone.js to remove this weird constraint.
|
Thanks for kicking this off! I'm wondering if we can support both v7 and 8 with this change-set so we don't have to bump our major. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: AngularFire now requires
firebase@^8.0.0Closes #2619
Checklist
yarn install,yarn testrun successfully? yesDescription
Make AngularFire compatible with Firebase JS SDK v8.