Skip to content

feat(analytics): Bunch of analytics & screen tracking improvements #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2020

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Nov 14, 2020

  • Better handle lazy routes
  • Better handle nested routes
  • Better handle nested & lazy routes
  • Handle multiple outlets correctly
  • Handle multiple outlets that share the same lazy components (this was tricky)
  • NO LONGER USING INTERNAL APIS OR REQUIRING ANNOTATIONS!!!! 🎉 😄
  • APP_NAME and APP_VERSION should be working now...
  • AngularFireAnalytics now gets it's measurementId from Analytics rather than your config, there's an edge case where this can change out from underneath you, which the JS SDK handles
  • Got DEBUG_MODE working again

@jamesdaniels jamesdaniels changed the title feat(analytics): Bunch of ScreenTrackingService improvements feat(analytics): Bunch of analytics & screen tracking improvements Nov 14, 2020
@jamesdaniels jamesdaniels merged commit b00e14b into master Nov 14, 2020
@jamesdaniels jamesdaniels deleted the 610-analytics branch November 14, 2020 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants