-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Updated id to $id #2831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated id to $id #2831
Conversation
"FirebaseDeploySchema" schema is using the keyword "id" which its support is deprecated. Now using "$id" for schema ID.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for the contribution, we won't be able to merge until the next major release as this would break older versions of Angular that we support. |
Thanks sorry I realised that after committing. |
This is fixed by latest minor release, right? |
I did not remove "id" (as this PR does) but added "$id" in 6.1.5 @KingDarBoja. I would consider this for inclusion in 7.0 which i just released the first alpha of. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
"FirebaseDeploySchema" schema is using the keyword "id" which its support is deprecated. Now using "$id" for schema ID.
Checklist
yarn install
,yarn test
run successfully? (yes/no; required)Description
Code sample