Skip to content

Updated id to $id #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 1, 2021
Merged

Updated id to $id #2831

merged 4 commits into from
Sep 1, 2021

Conversation

odenman250
Copy link
Contributor

"FirebaseDeploySchema" schema is using the keyword "id" which its support is deprecated. Now using "$id" for schema ID.

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

"FirebaseDeploySchema" schema is using the keyword "id" which its support is deprecated. Now using "$id" for schema ID.
@google-cla
Copy link

google-cla bot commented May 17, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jamesdaniels
Copy link
Member

Thanks for the contribution, we won't be able to merge until the next major release as this would break older versions of Angular that we support.

@odenman250
Copy link
Contributor Author

Thanks sorry I realised that after committing.

@KingDarBoja
Copy link
Contributor

This is fixed by latest minor release, right?

@jamesdaniels
Copy link
Member

I did not remove "id" (as this PR does) but added "$id" in 6.1.5 @KingDarBoja. I would consider this for inclusion in 7.0 which i just released the first alpha of.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Aug 19, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jamesdaniels jamesdaniels enabled auto-merge (squash) August 19, 2021 15:17
@jamesdaniels jamesdaniels merged commit b387b33 into angular:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants