Skip to content

7.1.0-rc.1 fixes #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 14, 2021
Merged

7.1.0-rc.1 fixes #2954

merged 10 commits into from
Sep 14, 2021

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Sep 14, 2021 •
edited
Loading

  • findModuleFromOptions wasn't working well when SSR was added to the mix, drop
  • shell out the logged in user(s)
  • fixed Cloud Functions dependencies all being dev
  • added file-loader dep so the Firestore loaders work out of box

@jamesdaniels jamesdaniels mentioned this pull request Sep 14, 2021
Closed
@jamesdaniels jamesdaniels changed the title 710 rc1 fixes 7.1.0-rc.1 fixes Sep 14, 2021
@jamesdaniels jamesdaniels merged commit 73bde38 into master Sep 14, 2021
@jamesdaniels jamesdaniels deleted the 710-rc0-fixes branch September 14, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesdaniels @googlebot