Skip to content

chore(release): Fix hang in the test suite #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 8, 2021
Merged

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Oct 8, 2021

Github Actions was a bit flaky last night, so I YOLO'd the tag... I had a real flake. This is why you don't try to push something out at 4am. I was just a test but it could've been a production issue.

  • Check for file existence before npm install on deploy, this was hanging up in some test environments
  • Prefer absolute paths on the deploy pipeline
  • Fix ng add stalling if you don't select any options

@jamesdaniels jamesdaniels changed the title Builds are stalling, this was a change try this fix chore(release): Fix hang in the test suite Oct 8, 2021
@jamesdaniels jamesdaniels merged commit bea9d67 into master Oct 8, 2021
@jamesdaniels jamesdaniels deleted the 710_build_fixes branch October 8, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants