Skip to content

fix: added missing injector input signatures #3191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export class FirebaseAppModule {
// Calling initializeApp({ ... }, 'name') multiple times will add more FirebaseApps into the FIREBASE_APPS
// injection scope. This allows developers to more easily work with multiple Firebase Applications. Downside
// is that DI for app name and options doesn't really make sense anymore.
export function provideFirebaseApp(fn: () => IFirebaseApp, ...deps: any[]): ModuleWithProviders<FirebaseAppModule> {
export function provideFirebaseApp(fn: (injector: Injector) => IFirebaseApp, ...deps: any[]): ModuleWithProviders<FirebaseAppModule> {
return {
ngModule: FirebaseAppModule,
providers: [{
Expand Down
2 changes: 1 addition & 1 deletion src/auth/auth.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class AuthModule {
}
}

export function provideAuth(fn: () => FirebaseAuth, ...deps: any[]): ModuleWithProviders<AuthModule> {
export function provideAuth(fn: (injector: Injector) => FirebaseAuth, ...deps: any[]): ModuleWithProviders<AuthModule> {
return {
ngModule: AuthModule,
providers: [{
Expand Down
2 changes: 1 addition & 1 deletion src/database/database.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class DatabaseModule {
}
}

export function provideDatabase(fn: () => FirebaseDatabase, ...deps: any[]): ModuleWithProviders<DatabaseModule> {
export function provideDatabase(fn: (injector: Injector) => FirebaseDatabase, ...deps: any[]): ModuleWithProviders<DatabaseModule> {
return {
ngModule: DatabaseModule,
providers: [{
Expand Down
2 changes: 1 addition & 1 deletion src/functions/functions.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class FunctionsModule {
}
}

export function provideFunctions(fn: () => FirebaseFunctions, ...deps: any[]): ModuleWithProviders<FunctionsModule> {
export function provideFunctions(fn: (injector: Injector) => FirebaseFunctions, ...deps: any[]): ModuleWithProviders<FunctionsModule> {
return {
ngModule: FunctionsModule,
providers: [{
Expand Down
2 changes: 1 addition & 1 deletion src/messaging/messaging.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class MessagingModule {
}
}

export function provideMessaging(fn: () => FirebaseMessaging, ...deps: any[]): ModuleWithProviders<MessagingModule> {
export function provideMessaging(fn: (injector: Injector) => FirebaseMessaging, ...deps: any[]): ModuleWithProviders<MessagingModule> {
return {
ngModule: MessagingModule,
providers: [{
Expand Down
2 changes: 1 addition & 1 deletion src/performance/performance.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export class PerformanceModule {
}
}

export function providePerformance(fn: () => FirebasePerformance, ...deps: any[]): ModuleWithProviders<PerformanceModule> {
export function providePerformance(fn: (injector: Injector) => FirebasePerformance, ...deps: any[]): ModuleWithProviders<PerformanceModule> {
return {
ngModule: PerformanceModule,
providers: [{
Expand Down
2 changes: 1 addition & 1 deletion src/remote-config/remote-config.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export class RemoteConfigModule {
}
}

export function provideRemoteConfig(fn: () => FirebaseRemoteConfig, ...deps: any[]): ModuleWithProviders<RemoteConfigModule> {
export function provideRemoteConfig(fn: (injector: Injector) => FirebaseRemoteConfig, ...deps: any[]): ModuleWithProviders<RemoteConfigModule> {
return {
ngModule: RemoteConfigModule,
providers: [{
Expand Down
2 changes: 1 addition & 1 deletion src/storage/storage.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class StorageModule {
}
}

export function provideStorage(fn: () => FirebaseStorage, ...deps: any[]): ModuleWithProviders<StorageModule> {
export function provideStorage(fn: (injector: Injector) => FirebaseStorage, ...deps: any[]): ModuleWithProviders<StorageModule> {
return {
ngModule: StorageModule,
providers: [{
Expand Down