Skip to content

fix(auth): Auth config for initializeApp #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2016
Merged

fix(auth): Auth config for initializeApp #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a54ceae
fix(auth): Auth config for initializeApp
davideast Aug 12, 2016
5039a4b
mend
davideast Aug 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"test:watch": "karma start",
"build": "rm -rf dist; tsc",
"build:watch": "rm -rf dist && tsc -w",
"build_npm": "rm -rf dist && ngc -p tsconfig.publish.es5.json && ngc -p tsconfig.publish.es6.json",
"postbuild_npm": "cp manual_typings/firebase3/firebase3.d.ts package.json README.md .npmignore dist/ && npm run rewrite_npm_package",
"build_npm": "rm -rf dist && ngc -p tsconfig.publish.es5.json && ngc -p tsconfig.publish.es6.json && npm run postbuild_npm",
"postbuild_npm": "cp package.json README.md .npmignore dist/ && npm run rewrite_npm_package",
"rewrite_npm_package": "node --harmony_destructuring tools/rewrite-published-package.js",
"e2e_test": "webdriver-manager update && npm run build_e2e && protractor",
"build_e2e": "rm -rf dist-test && npm run build && tsc -p test/ && cp test/e2e/firebase_object/index.html dist-test/e2e/firebase_object/ && cp test/e2e/firebase_list/index.html dist-test/e2e/firebase_list/ && cp test/e2e/auth/index.html dist-test/e2e/auth/",
Expand Down
3 changes: 2 additions & 1 deletion src/angularfire2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { initializeApp } from 'firebase';
import * as utils from './utils';
import { FirebaseAppConfig } from './interfaces';
import { AuthConfiguration } from './auth';
import {
FirebaseListFactoryOpts,
FirebaseObjectFactoryOpts,
Expand Down Expand Up @@ -109,7 +110,7 @@ export const defaultFirebase = (config: FirebaseAppConfig): any => {
providers: FIREBASE_PROVIDERS
})
export class AngularFireModule {
static initializeApp(config: FirebaseAppConfig, authConfig?:FirebaseAppConfig): ModuleWithProviders {
static initializeApp(config: FirebaseAppConfig, authConfig?:AuthConfiguration): ModuleWithProviders {
return {
ngModule: AngularFireModule,
providers: [
Expand Down
2 changes: 0 additions & 2 deletions src/auth/auth_backend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ export enum AuthMethods {
export interface AuthConfiguration {
method?: AuthMethods;
provider?: AuthProviders;
remember?: string;
scope?: string[];
}

export interface FirebaseAuthState {
Expand Down