Make the $key and $exists properties non-enumerable #535
Conversation
Making these keys non enumerable makes sure that you can use Object.keys() and Object.values on the unwrapped value without having the extra properties to account for.
|
@meDavid This is awesome! Can you write a unit test to verify the behavior? |
|
Good stuff! c[]c[] @davideast what version of IE do we support? I'm pretty sure 8 (maybe 9) needs a polyfill for this. |
|
@katowulf Angular 2 only supports back to IE10. |
|
Perfect. We just need test units then, @meDavid |
|
Any chance we can get the test units in for this? |
|
@katowulf Yes, I will make it happen in the next couple of days |
|
Very useful. Any updates regards this? |
- sync origin
…erties # Conflicts: # src/database/firebase_object_observable.spec.ts
|
@katowulf @davideast I updated the pullrequest with an additional test to see if the behavior is correct. If you have any suggestions for improvements, let me know. |
|
@meDavid Thank you so much! There appears to be a merge conflict, however. Can you get that sorted out and then we'll do a review to merge in? |
|
@davideast I don't see any merge conflict, only a rebase conflict but I don't know how to resolve that. Any pointers? |
|
@meDavid I'm not 100% either, but you can try to follow this guide here or simply store your changes locally, resync the fork/delete it and re-fork, and then reapply your changes. |
|
@meDavid Any updates on this? I ran into this recently myself and I just deleted my fork and moved my changes over to the new one. You lose history, but it works. |
|
Patched these changes in locally, works brilliantly! C'mon @meDavid, new branch and new PR to quick fix, you deserve the commit creds. |
|
@byrondover I'll find some time this weekend |
|
superseded by #787 |
Making these keys non enumerable makes sure that you can use Object.keys() and Object.values on the unwrapped value without having the extra properties to account for.
This would also resolve #302