Skip to content

Datepicker: datepicker is shown partially when inside a modal #4786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adaojunior opened this issue May 24, 2017 · 8 comments
Closed

Datepicker: datepicker is shown partially when inside a modal #4786

adaojunior opened this issue May 24, 2017 · 8 comments

Comments

@adaojunior
Copy link

Bug:

Datepicker is shown only partially when inside a modal

What are the steps to reproduce?

screen shot 2017-05-24 at 4 55 02 pm

See, it is missing the last week of the month.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Google Chrome - Version 58.0.3029.110 (64-bit)

@willshowell
Copy link
Contributor

Duplicate of #4406

@fxck
Copy link
Contributor

fxck commented May 24, 2017

Not really I don't think @willshowell I'm running a version with #4696 in and it's still broken inside a modal.

@willshowell
Copy link
Contributor

@fxck I just ran that PR as is (4a47f89) and it seems to be working fine

screen shot 2017-05-24 at 5 46 29 pm

@julianobrasil
Copy link
Contributor

julianobrasil commented May 29, 2017

@willshowell, another thing is that it's fixed on the screen, so when you resize the view port, the dialog mooves to try to stay at the center, but the date picker seems to stick where it initially was. I'm using Material Beta.6.

image

After resizing:

image

@willshowell
Copy link
Contributor

@adaojunior @julianobrasil could you check against the master build? #4696 was merged after the beta-6 release.

@julianobrasil
Copy link
Contributor

julianobrasil commented May 30, 2017

@willshowell , it worked for me (it follows the dialog when the view port is resized and the dialog tries to stay centered). Also it pops up in the most logical direction (upwards if the component is near the bottom of the viewport, and downwards if the input is near the top). And the directions switches to fit better when you resize.

@mmalerba
Copy link
Contributor

sounds like this has been fixed

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants