Skip to content

Not clear how/when DateAdapter parse is called #6335

Closed
@james-schwartzkopf

Description

@james-schwartzkopf

Looking through master I can tell some changes have been made since beta-8, but it's still not clear when/how DateAdapter parse is called.

As far as I can tell after the new changes parse is only called with string values from the input element, but it's still defined as abstract parse(value: any, parseFormat: any): D | null;, and unit test are still passing it numbers and Date objects.

In beta-8 parse was getting called with model values that were set on the input. This made it difficult to implement DateAdapter<string> since I couldn't tell which strings were from the model (expected to be in ISO 8601 format), and those from the user (expected to be in a format like MM-DD-YYYY).

I'm hoping the changes mean parse will only ever be called with a formatted string from the input or similar, but can't tell from the current docs/interface.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions