Skip to content

demo-app is not runnabe #8810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
e-cloud opened this issue Dec 5, 2017 · 3 comments
Closed

demo-app is not runnabe #8810

e-cloud opened this issue Dec 5, 2017 · 3 comments
Assignees

Comments

@e-cloud
Copy link
Contributor

e-cloud commented Dec 5, 2017

Bug, feature request, or proposal:

bug

What is the expected behavior?

we should be able run demo-app without errors on master branch

What is the current behavior?

running demo-app prompts a lot of errors and unable to start the server.

What are the steps to reproduce?

  1. pull the master branch, my current ref is: 0b2757c
  2. install deps with yarn
  3. run yarn demo-app

What is the use-case or motivation for changing an existing behavior?

we should ensure someone who changes the source will also update the demo code to prove its correctness to a certain extent.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

not sure

Is there anything else we should know?

I suggest putting the demo-app deployment command into CI scripts. Not for deployment but for testing.

@crisbeto crisbeto self-assigned this Dec 5, 2017
@crisbeto crisbeto added the has pr label Dec 5, 2017
@e-cloud
Copy link
Contributor Author

e-cloud commented Dec 7, 2017

@crisbeto can you point out the PR number?

@crisbeto
Copy link
Member

crisbeto commented Dec 7, 2017

#8811 and #8824 @e-cloud.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants