Skip to content

chore: fix demo app compilation error #8811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 5, 2017

Fixes a compilation error in the demo app when running on a fresh install.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 5, 2017
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 5, 2017
@@ -639,7 +639,7 @@ class FakeDataSource extends DataSource<TestData> {
connect(collectionViewer: CollectionViewer) {
this.isConnected = true;
const streams = [this._dataChange, collectionViewer.viewChange];
return combineLatest<TestData[]>(streams).pipe(map(([data]) => data));
return combineLatest<TestData[][]>(streams).pipe(map(([data]) => data));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combineLatest(streams, (data, _) => data);

Fixes a compilation error in the demo app when running on a fresh install.
@crisbeto crisbeto force-pushed the 8810/demo-app-error branch from 5e3ddf3 to 2a32551 Compare December 5, 2017 17:29
@mmalerba mmalerba merged commit 5690c87 into angular:master Dec 5, 2017
@crisbeto crisbeto mentioned this pull request Dec 7, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants