Skip to content

feat(virtual-scroll): move from cdk-experimental to cdk #12438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2018
Merged

feat(virtual-scroll): move from cdk-experimental to cdk #12438

merged 3 commits into from
Aug 1, 2018

Conversation

mmalerba
Copy link
Contributor

Moves the various virtual scrolling parts to the cdk, except for the AutosizeVirtualScrollStrategy which will remain in cdk-experimental for now.

fixes #823

@mmalerba mmalerba requested review from amcdnl, jelbourn and crisbeto July 30, 2018 16:26
@mmalerba mmalerba requested a review from andrewseguin as a code owner July 30, 2018 16:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 30, 2018
@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Jul 30, 2018
jelbourn
jelbourn approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

jelbourn commented Jul 30, 2018 •
edited
Loading

Actually looks like there are some CI failures

crisbeto
crisbeto approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 1, 2018
@ngbot
Copy link

ngbot bot commented Aug 1, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba
Copy link
Contributor Author

mmalerba commented Aug 1, 2018

travis failure is unrelated

@jelbourn jelbourn merged commit dcd2282 into angular:master Aug 1, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Virtual scrolling helpers / utilities.
5 participants
@mmalerba @jelbourn @crisbeto @amcdnl @googlebot