-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build(bazel): building Angular from source for MatButton and parts of CDK #13109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Hey there, I had actually gone down this road already and found that the result doesn't work for unit tests and the |
Hi @mattem! This PR has merge conflicts due to recent upstream merges. |
@jelbourn Ah I haven't tried this with running the tests or the |
All the bazel stuff is on the back-burner at least until v7 is out. I had it successfully building all the ng_module rules, but everything else was broken. The next step would be to figure out why the test rules are broken. |
I believe v7 is out. I hope it will help make Bazel usable now? |
FYI. Downstream material with bazel is now supported. #13836 landed and example of usage is here angular/angular-bazel-example#228. |
Closing this PR as it's superseded by @gregmagolan PRs and work above. Thanks! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@alexeagle This was a rough first pass, just trying to get something working. The main parts were removing
module.id
in all the components (they are commented out here in here) and adding the right dependencies to parts of MatButton and CDK.I've not tested the regular bundling of Material after these changes!