Skip to content

build(bazel): building Angular from source for MatButton and parts of CDK #13109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

build(bazel): building Angular from source for MatButton and parts of CDK #13109

wants to merge 1 commit into from

Conversation

mattem
Copy link

@mattem mattem commented Sep 13, 2018

@alexeagle This was a rough first pass, just trying to get something working. The main parts were removing module.id in all the components (they are commented out here in here) and adding the right dependencies to parts of MatButton and CDK.

I've not tested the regular bundling of Material after these changes!

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Sep 13, 2018
@jelbourn
Copy link
Member

Hey there, I had actually gone down this road already and found that the result doesn't work for unit tests and the ng_package rules, which I consider to be a hard requirement for the change.

@ngbot
Copy link

ngbot bot commented Sep 14, 2018

Hi @mattem! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@mattem
Copy link
Author

mattem commented Sep 14, 2018

@jelbourn Ah I haven't tried this with running the tests or the ng_package rule. I threw this together as a PoC for @alexeagle and the Angular Bazel example project.
Do you have any thoughts on the direction this should take in order to get it working?

@jelbourn
Copy link
Member

All the bazel stuff is on the back-burner at least until v7 is out. I had it successfully building all the ng_module rules, but everything else was broken. The next step would be to figure out why the test rules are broken.

@josephperrott josephperrott removed their request for review October 1, 2018 13:35
@johnbendi
Copy link

I believe v7 is out. I hope it will help make Bazel usable now?

@gregmagolan
Copy link
Contributor

FYI. Downstream material with bazel is now supported. #13836 landed and example of usage is here angular/angular-bazel-example#228.

@mattem
Copy link
Author

mattem commented Nov 8, 2018

Closing this PR as it's superseded by @gregmagolan PRs and work above. Thanks!

@mattem mattem closed this Nov 8, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants