Skip to content

feat(google-maps): Add map-info-window component #17027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 23, 2019

Conversation

mbehrlich
Copy link
Collaborator

Add component that implements the Google Maps JavaScript API InfoWindow
that displays on the Google Map and can be anchored to a marker.

@mbehrlich mbehrlich requested review from jelbourn and a team as code owners September 10, 2019 02:40
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 10, 2019
Add component that implements the Google Maps JavaScript API InfoWindow
that displays on the Google Map and can be anchored to a marker.
Fix type error with getPosition test.
Fix import statement for info window by adding /index.
Refactor code so that parent map is injected in info window instead of
loading info window in the map.
Remove BUILD files to conform with the recent fix for the npm package.
Fix lint errors for features missing in the info window component. Add
comment to style to explain its function.
Change MapInfoWindow from a component to a directive.
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Sep 23, 2019
@jelbourn jelbourn merged commit 30de283 into angular:master Sep 23, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants