feat(google-maps): Add map-info-window component #17027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Sep 12, 2019
jelbourn
reviewed
Sep 19, 2019
Add component that implements the Google Maps JavaScript API InfoWindow that displays on the Google Map and can be anchored to a marker.
Fix type error with getPosition test.
Fix import statement for info window by adding /index.
Refactor code so that parent map is injected in info window instead of loading info window in the map.
Remove BUILD files to conform with the recent fix for the npm package.
Fix lint errors for features missing in the info window component. Add comment to style to explain its function.
Change MapInfoWindow from a component to a directive.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add component that implements the Google Maps JavaScript API InfoWindow
that displays on the Google Map and can be anchored to a marker.