test(multiple): refactor unit tests of several components#22952
Merged
wagnermaciel merged 1 commit intoangular:masterfrom Jun 11, 2021
Merged
Conversation
nitinmalave
requested review from
crisbeto,
devversion,
jelbourn and
mmalerba
as code owners
google-cla
bot
added
the
cla: yes
nitinmalave
force-pushed
the
refactor-dialog-component-unit-tests
branch
from
67e253c to
e16fd9c
Compare
crisbeto
reviewed
Jun 11, 2021
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
The changes look good, but the commit title needs to be updated to say test(multiple instead of test(material/multiple).
nitinmalave
changed the title
nitinmalave
force-pushed
the
refactor-dialog-component-unit-tests
branch
from
e16fd9c to
6079480
Compare
Contributor
Author
|
Fixed it. |
crisbeto
added
action: merge
wagnermaciel
pushed a commit
that referenced
this pull request
Jun 11, 2021
(cherry picked from commit 30cfd7d)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this PR as it is required to: