Skip to content

fix(material-experimental/mdc-checkbox): switch to non-deprecated styles #23218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2022
Merged

fix(material-experimental/mdc-checkbox): switch to non-deprecated styles #23218

merged 1 commit into from
Jan 7, 2022

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 22, 2021

Switches the MDC-based checkbox to the non-deprecated styles.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release labels Jul 22, 2021
@crisbeto crisbeto requested review from jelbourn and mmalerba July 22, 2021 14:48
@crisbeto crisbeto requested a review from devversion as a code owner July 22, 2021 14:48
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 22, 2021
@crisbeto crisbeto force-pushed the mdc-checkbox-deprecated-styles branch from 7346100 to 198e1bd Compare July 22, 2021 14:53
@mmalerba mmalerba added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Jul 23, 2021
@mmalerba
Copy link
Contributor

mmalerba commented Jul 23, 2021 •
edited
Loading

changing to patch since it only affects experimental

mmalerba
mmalerba reviewed Jul 23, 2021
View reviewed changes
@crisbeto crisbeto force-pushed the mdc-checkbox-deprecated-styles branch 2 times, most recently from 1a082f5 to 1bf2f21 Compare July 30, 2021 16:14
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 30, 2021
jelbourn
jelbourn approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devversion devversion removed their request for review August 18, 2021 13:15
@crisbeto crisbeto force-pushed the mdc-checkbox-deprecated-styles branch from 1bf2f21 to 41ba018 Compare September 21, 2021 17:02
@crisbeto crisbeto changed the title feat(material-experimental/mdc-checkbox): switch to non-deprecated styles fix(material-experimental/mdc-checkbox): switch to non-deprecated styles Oct 11, 2021
@crisbeto crisbeto force-pushed the mdc-checkbox-deprecated-styles branch from 41ba018 to b3d7492 Compare October 11, 2021 06:48
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@crisbeto
fix(material-experimental/mdc-checkbox): switch to non-deprecated styles
cf5a739 
Switches the MDC-based checkbox to the non-deprecated styles.
@crisbeto crisbeto force-pushed the mdc-checkbox-deprecated-styles branch from b3d7492 to cf5a739 Compare January 3, 2022 09:16
@wagnermaciel wagnermaciel merged commit a5fb8f8 into angular:master Jan 7, 2022
wagnermaciel pushed a commit that referenced this pull request Jan 7, 2022
@crisbeto @wagnermaciel
fix(material-experimental/mdc-checkbox): switch to non-deprecated sty…
ae9f3d5 
…les (#23218)

Switches the MDC-based checkbox to the non-deprecated styles.

(cherry picked from commit a5fb8f8)
zarend pushed a commit to zarend/components that referenced this pull request Jan 7, 2022
@crisbeto @zarend
fix(material-experimental/mdc-checkbox): switch to non-deprecated sty…
8e8384d 
…les (angular#23218)

Switches the MDC-based checkbox to the non-deprecated styles.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Feb 7, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba mmalerba left review comments

@andrewseguin andrewseguin andrewseguin left review comments

@jelbourn jelbourn jelbourn approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@crisbeto @mmalerba @jelbourn @andrewseguin @googlebot @wagnermaciel