Skip to content

fix(google-maps): update to latest typings #26854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crisbeto merged 1 commit into from
Mar 29, 2023
Merged

fix(google-maps): update to latest typings #26854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"@angular/core": "^16.0.0-next.2",
"@angular/forms": "^16.0.0-next.2",
"@angular/platform-browser": "^16.0.0-next.2",
"@types/google.maps": "^3.47.3",
"@types/google.maps": "^3.52.4",
"@types/youtube": "^0.0.46",
"rxjs": "^6.6.7",
"rxjs-tslint-rules": "^4.34.8",
Expand Down
2 changes: 1 addition & 1 deletion src/google-maps/google-map/google-map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ export class GoogleMap implements OnChanges, OnInit, OnDestroy {
* See
* https://developers.google.com/maps/documentation/javascript/reference/map#Map.overlayMapTypes
*/
get overlayMapTypes(): google.maps.MVCArray<google.maps.MapType> {
get overlayMapTypes(): google.maps.MVCArray<google.maps.MapType | null> {
this._assertInitialized();
return this.googleMap.overlayMapTypes;
}
Expand Down
2 changes: 1 addition & 1 deletion src/google-maps/map-marker/map-marker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ export class MapMarker implements OnInit, OnChanges, OnDestroy, MapAnchorPoint {
* See
* developers.google.com/maps/documentation/javascript/reference/marker#Marker.getLabel
*/
getLabel(): google.maps.MarkerLabel | null {
getLabel(): google.maps.MarkerLabel | string | null {
this._assertInitialized();
return this.marker.getLabel() || null;
}
Expand Down
2 changes: 1 addition & 1 deletion src/google-maps/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
},
"homepage": "https://github.com/angular/components/tree/main/src/google-maps#readme",
"dependencies": {
"@types/google.maps": "^3.45.6",
"@types/google.maps": "^3.52.4",
"tslib": "0.0.0-TSLIB"
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions tools/public_api_guard/google-maps/google-maps.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export class GoogleMap implements OnChanges, OnInit, OnDestroy {
ngOnInit(): void;
// (undocumented)
set options(options: google.maps.MapOptions);
get overlayMapTypes(): google.maps.MVCArray<google.maps.MapType>;
get overlayMapTypes(): google.maps.MVCArray<google.maps.MapType | null>;
panBy(x: number, y: number): void;
panTo(latLng: google.maps.LatLng | google.maps.LatLngLiteral): void;
panToBounds(latLngBounds: google.maps.LatLngBounds | google.maps.LatLngBoundsLiteral, padding?: number | google.maps.Padding): void;
Expand Down Expand Up @@ -412,7 +412,7 @@ export class MapMarker implements OnInit, OnChanges, OnDestroy, MapAnchorPoint {
getCursor(): string | null;
getDraggable(): boolean;
getIcon(): string | google.maps.Icon | google.maps.Symbol | null;
getLabel(): google.maps.MarkerLabel | null;
getLabel(): google.maps.MarkerLabel | string | null;
getOpacity(): number | null;
getPosition(): google.maps.LatLng | null;
getShape(): google.maps.MarkerShape | null;
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4044,10 +4044,10 @@
"@types/minimatch" "*"
"@types/node" "*"

"@types/google.maps@^3.47.3":
version "3.48.6"
resolved "https://registry.yarnpkg.com/@types/google.maps/-/google.maps-3.48.6.tgz#5125eb8257beb031b547acb5a690c24c3cabbf59"
integrity sha512-ZSx2J50Q9qyHhYVO4UdTvt5sHILzenSCiMbr7bjYNCMBkW/sagHMEDPI3Vjlr9i2tlMHIGoLk6DthWJnqFun/A==
"@types/google.maps@^3.52.4":
version "3.52.4"
resolved "https://registry.yarnpkg.com/@types/google.maps/-/google.maps-3.52.4.tgz#01d640d7c49f153570b22fe337a35aea7ac41eb9"
integrity sha512-FXtZsLDX7fbxJ03zbze3MdUjaH4Y/zRmW8O65LNIWEHJ7RqddrabusRm/U3zF1ifmqe8y4oPqBvs+vBG8kv0yQ==

"@types/http-cache-semantics@*":
version "4.0.1"
Expand Down