fix(autocomplete): throw better error when autocomplete doesn't have a panel #4851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
approved these changes
May 30, 2017
| @@ -1156,6 +1161,15 @@ describe('MdAutocomplete', () => { | |||
| expect(fixture.componentInstance.mdOptions.length).toBe(2); | |||
| })); | |||
|
|
|||
| it('should not throw if the user attempts to open the panel too early', async(() => { | |||
There was a problem hiding this comment.
This test name seems to be backwards. It should throw the error, right?
kara
added
pr: lgtm
action: merge
…a panel Adds a more informative error if the user tries to open an autocomplete that doesn't exist or hasn't been defined yet by the `@ViewChild` query. Fixes angular#4844.
crisbeto
force-pushed
the
4844/autocomplete-better-error
branch
from
636b980 to
e8ce88f
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a more informative error if the user tries to open an autocomplete that doesn't exist or hasn't been defined yet by the
@ViewChildquery.Fixes #4844.