Skip to content

fix(sidenav): animate sidenav on open/close changes #6064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

andrewseguin
Copy link
Contributor

Fixes issue where sidenavs that are initialized as open are showing the transition due to the new change detection onpush changes

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 26, 2017
@andrewseguin andrewseguin added pr: needs review and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jul 26, 2017
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although the onOpenStart and onCloseStart will be gone once #4959 is merged in. I can check whether it's still an issue there.

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 26, 2017
@andrewseguin
Copy link
Contributor Author

Would prefer to check in #4959 over this if it can fix this issue.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 26, 2017
@crisbeto
Copy link
Member

Do we have a repro case? I can give it a try.

@crisbeto
Copy link
Member

Tried it out against a few examples from the demo app @andrewseguin and it doesn't look like #4959 would resolve the issue. I'll see if I can get a workaround there as well.

@crisbeto
Copy link
Member

crisbeto commented Jul 26, 2017

Alright, I've updated #4959 to fix the initial animation as well. Here's the commit: 4f96e56

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants