feat(sidenav): add responsive sidenav #6525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add responsive sidenav * Close and open depending on width Fix #1130
googlebot
added
the
cla: yes
* Used window width instead of element width
willshowell
reviewed
Aug 17, 2017
| * Note that this only works when the window is rezied. | ||
| * If you resize it some other way, call checkBreakpoint(). | ||
| */ | ||
| @HostListener('window:resize', ['$event']) |
Contributor
There was a problem hiding this comment.
This should be debounced. See https://github.com/angular/material2/blob/master/src/lib/tabs/tab-header.ts#L182-L195
willshowell
reviewed
Aug 17, 2017
Contributor
willshowell
left a comment
willshowell
left a comment
There was a problem hiding this comment.
Also thanks for putting this together! I've personally been really looking forward to it.
| checkBreakpoint() { | ||
| if (this._element.nativeElement.offsetWidth < this.breakpointWidth) { | ||
| if (this.breakpointChangeMode) | ||
| this._sidenavs.forEach(sidenav => sidenav.mode = "over"); |
Contributor
There was a problem hiding this comment.
Use curly braces here and below
Author
|
Starting new branch because of drawer/sidenav being split. |
Closed
Author
|
New version: #6535 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1130