fix: import individual rx operators#8160
Merged
andrewseguin merged 1 commit intoangular:masterfrom Oct 31, 2017
Merged
Conversation
After the switch to lettable operators, we had started importing all operators via `rxjs/operators`. These changes switch us back to only importing the individual ones and add some linting so it doesn't happen in the future.
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn,
josephperrott,
kara,
mmalerba and
tinayuangao
as code owners
googlebot
added
the
cla: yes
mmalerba
approved these changes
Oct 31, 2017
mmalerba
added
pr: lgtm
action: merge
Contributor
|
LGTM - thanks for doing all the work |
CaerusKaru
added a commit
to CaerusKaru/flex-layout
that referenced
this pull request
Oct 31, 2017
* Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160
andrewseguin
added
the
P1
|
@crisbeto After reading about the option to us lettable operators in the ng 5 annoucement blog I was wondering why the ng Material team has chosen to use the deep lettable operators compared to the ones mentioned in the blog or in the rxjs repo docs . Does the approach you've chosen work better at scale, does it cause fewer issues with build systems or is it to support older versions of Typescript? Just curious! Thanks! |
CaerusKaru
added a commit
to CaerusKaru/flex-layout
that referenced
this pull request
Nov 7, 2017
* Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160
CaerusKaru
added a commit
to CaerusKaru/flex-layout
that referenced
this pull request
Nov 7, 2017
* Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160
CaerusKaru
added a commit
to CaerusKaru/flex-layout
that referenced
this pull request
Nov 24, 2017
* Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160
CaerusKaru
added a commit
to CaerusKaru/flex-layout
that referenced
this pull request
Nov 24, 2017
* Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160
CaerusKaru
added a commit
to CaerusKaru/flex-layout
that referenced
this pull request
Nov 24, 2017
* Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160
CaerusKaru
added a commit
to CaerusKaru/flex-layout
that referenced
this pull request
Nov 25, 2017
* Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160
CaerusKaru
added a commit
to CaerusKaru/flex-layout
that referenced
this pull request
Dec 7, 2017
* fix: import individual rx operators * Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160
CaerusKaru
added a commit
to CaerusKaru/flex-layout
that referenced
this pull request
Dec 14, 2017
* fix: import individual rx operators * Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160
CaerusKaru
added a commit
to CaerusKaru/flex-layout
that referenced
this pull request
Dec 14, 2017
* fix: import individual rx operators * Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160
CaerusKaru
added a commit
to CaerusKaru/flex-layout
that referenced
this pull request
Dec 14, 2017
* fix: import individual rx operators * Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160
ThomasBurleson
pushed a commit
to angular/flex-layout
that referenced
this pull request
Dec 14, 2017
Updates rxjs to latest best practices * fix: import individual rx operators * Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160 Fixes #519, #508, #533. Closes #474.
atscott
pushed a commit
to atscott/flex-layout
that referenced
this pull request
Feb 3, 2018
Updates rxjs to latest best practices * fix: import individual rx operators * Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160 Fixes angular#519, angular#508, angular#533. Closes angular#474.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the switch to lettable operators, we had started importing all operators via
rxjs/operators. These changes switch us back to only importing the individual ones and adds some linting so it doesn't happen in the future.