Skip to content

chore: fix test compilation #8430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 14, 2017

Fixes a compilation error in the table tests and fixes the package-lock not being up to date.

Note: The tests currently time out. They'll be fixed by #8385.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 14, 2017
@crisbeto crisbeto force-pushed the table-spec-compilation branch from ee2df20 to 36cdddb Compare November 14, 2017 08:19
Fixes a compilation error in the table tests and fixes the package-lock not being up to date.
@crisbeto crisbeto force-pushed the table-spec-compilation branch from 36cdddb to f7947c3 Compare November 14, 2017 08:20
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 14, 2017
@jelbourn jelbourn merged commit 3510064 into angular:master Nov 14, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants