Skip to content

docs: add descriptions to properties initialized through the constructor #8803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 4, 2017

Adds the missing docs to some of the properties that are declared through the constructor params.

Fixes #8789.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 4, 2017
constructor(
/** Reference to the autocomplete panel that emitted the event. */
public source: MatAutocomplete,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for consistency, can you do the blank line in all of the files or none of them

Adds the missing docs to some of the properties that are declared through the constructor params.

Fixes angular#8789.
@crisbeto crisbeto force-pushed the 8789/constructor-prop-docs branch from 06e30ca to 9baa5e7 Compare December 5, 2017 16:42
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Dec 5, 2017
@mmalerba mmalerba merged commit bf52a19 into angular:master Dec 5, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing docs for properties declared in constructor of Change classes
3 participants