This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Ng schematics service #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jschwarty PR #29 contains the updates for module resolutions. |
20 tasks
jschwarty
force-pushed
the
ng-schematics-service
branch
from
56abe48 to
8fb84b5
Compare
Brocco
suggested changes
Jul 13, 2017
| } | ||
|
|
||
| let modulePath; | ||
| if (options.module) { |
There was a problem hiding this comment.
This check is redundant (see line 33)
Once that's removed modulePath can be a const instead of being let and set on line 42.
There was a problem hiding this comment.
Something like this?
if (!options.module) {
return host;
}
const modulePath = options.module;
if (!host.exists(options.module)) {
throw new Error(`Module specified (${options.module}) does not exist.`);
}
Brocco
reviewed
Jul 13, 2017
package-lock.json
Outdated
| @@ -12,10 +12,14 @@ | |||
| "@ngtools/logger": { | |||
There was a problem hiding this comment.
There should be no changes to package-lock.json in this PR either
There was a problem hiding this comment.
That's a bad merge. just reset it.
jschwarty
force-pushed
the
ng-schematics-service
branch
from
8fb84b5 to
021a02e
Compare
hansl
reviewed
Jul 13, 2017
| template, | ||
| url, | ||
| } from '@angular-devkit/schematics'; | ||
| import * as stringUtils from '../strings'; |
There was a problem hiding this comment.
Please merge all import groups together (this is different than the CLI repo).
There was a problem hiding this comment.
So just no empty line here between import lines, correct?
jschwarty
force-pushed
the
ng-schematics-service
branch
from
021a02e to
2a089e2
Compare
Brocco
approved these changes
Jul 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a
TODOin there for the module name option as per discussion with @Brocco. Also, thepackage-lock.jsonfile is in here. Not sure what the plan is to handle that as it changes from dev to dev. Let me know if I need to do anything on that.