This repository was archived by the owner on Apr 4, 2025. It is now read-only.
refactor: Update rxjs operators to be lettable. #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dependent upon angular/angular-cli#8976 |
CaerusKaru
reviewed
Dec 24, 2017
| @@ -6,21 +6,19 @@ | |||
| * found in the LICENSE file at https://angular.io/license | |||
| */ | |||
| // tslint:disable:no-any | |||
| import 'rxjs/add/operator/filter'; | |||
| import 'rxjs/add/operator/map'; | |||
| import { filter, map, toArray } from 'rxjs/operators'; | |||
There was a problem hiding this comment.
These should be separate imports:
import { filter } from 'rxjs/operators/filter';
...
There was a problem hiding this comment.
Per discussion in angular/angular-cli#8976 (comment), this is a non-starter/not necessary
Brocco
force-pushed
the
lettable
branch
5 times, most recently
from
4b3024d to
b2147e1
Compare
Brocco
force-pushed
the
lettable
branch
5 times, most recently
from
68ea42e to
5a0c16d
Compare
clydin
approved these changes
Jan 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.