This repository was archived by the owner on Apr 4, 2025. It is now read-only.
feat(@angular-devkit/build-angular): pass config\command line\environment parameters to code #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment parameters to code
Add more control on build process:
1) pass parameter known only at build stage to source code using command line argument
or environment variable
2) define different values in code for different apps and architects
3) strip off some parts of code for some apps and architects
How to use
angular.json:
"defines": [
{
"name": "DEFINE_OPTION",
"value": false
},
{
"name": "ENV_OPTION",
"value": "process.env.TEST_ENV_DEFINES"
},
{
"name": "COMMAND_LINE_OPTION",
"value": "buildOptions._customCommandLineOption"
},
{
"name": "CALC_OPTION",
"targets": {
"production": "283745620252 + 1",
"development": "2 + 2"
}
}
]
code:
declare var DEFINE_OPTION: boolean;
declare var ENV_OPTION: string;
declare var COMMAND_LINE_OPTION: string;
declare var CALC_OPTION: number;
if (DEFINE_OPTION){
//stripped off
}
run:
set TEST_ENV_DEFINES=env_value
ng build --_customCommandLineOption=42
angular/angular-cli#10521
…ment parameters to code
Add more control on build process:
1) pass parameter known only at build stage to source code using command line argument
or environment variable
2) define different values in code for different apps and architects
3) strip off some parts of code for some apps and architects
How to use
angular.json:
"defines": [
{
"name": "DEFINE_OPTION",
"value": false
},
{
"name": "ENV_OPTION",
"value": "process.env.TEST_ENV_DEFINES"
},
{
"name": "COMMAND_LINE_OPTION",
"value": "buildOptions._customCommandLineOption"
},
{
"name": "CALC_OPTION",
"targets": {
"production": "283745620252 + 1",
"development": "2 + 2"
}
}
]
code:
declare var DEFINE_OPTION: boolean;
declare var ENV_OPTION: string;
declare var COMMAND_LINE_OPTION: string;
declare var CALC_OPTION: number;
if (DEFINE_OPTION){
//stripped off
}
run:
set TEST_ENV_DEFINES=env_value
ng build --_customCommandLineOption=42
angular/angular-cli#10521
…ment parameters to code - extract custom build options to subobject options.customOptions
…ment parameters to code Merge remote-tracking branch 'remotes/origin/webpack-define_plugin-support' into webpack-define_plugin-support
…ment parameters to code use forEach instead of map to filter custom options
…ment parameters to code change timeouts in test
…mentparameters to code Merge branch 'master' into webpack-define_plugin-support
Flybbit
force-pushed
the
webpack-define_plugin-support
branch
from
35cdbe5 to
a2e366e
Compare
|
In angular/angular-cli#10521 (comment) I talked a bit about why we don't want to add this functionality and a current alternative. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more control on build process:
or environment variable
How to use
angular.json:
code:
run:
set TEST_ENV_DEFINES=env_value ng build --_customCommandLineOption=42Issue #10521