Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

angular-material breaks our app by just being included as a dependency #3941

Closed
smashercosmo opened this issue Jul 29, 2015 · 7 comments
Closed
Assignees
Milestone

Comments

@smashercosmo
Copy link

Here is a simple plunker that illustrates an issue. We have a transcluded form with ng-repeat inside and custom validation directive on inputs. Form has an ng-show directive, but as you will see it is always hidden.

  1. If you remove ngMaterial dependency everything will work.
  2. If you remove transclusion directive everything will work.
  3. If you remove ng-repeat directive everything will work
  4. If you remove any of the custom validation directives... everything will work.

Only combination of these four causes the form to not show up.

@ghost
Copy link

ghost commented Jul 29, 2015

@smashercosmo It's an issue with your directives. There is a name confict. Rename (namespace) your directives that are affected and it works.

@smashercosmo
Copy link
Author

@robertbaker no, it's not. I updated plunker with renamed (namespaced) directives. still not working.

@bolerodan
Copy link

@smashercosmo I believe it's an issue with Angular 1.4 and angular-material specifically. I changed versions of angular to 1.3.10 in your plunker and it seems to work. I recall this library also having an issue with 1.4 animation and if I recall, they rolled back to require an older version of angular? Maybe someone else can chime in here.

@ThomasBurleson
Copy link
Contributor

@smashercosmo - The issues that ngMaterial has with ngAnimate should all be solved once the PR #3949 has been merged into master.

These fixes are scheduled for formal release with v0.11; but, of course, will be available in master... planned for merging into master next week.

@ThomasBurleson ThomasBurleson added this to the 0.11.0 milestone Jul 31, 2015
@ThomasBurleson ThomasBurleson self-assigned this Jul 31, 2015
@smashercosmo
Copy link
Author

@ThomasBurleson just want you to know, I've just tested with latest master, that includes #3949, but issue is still not resolved :(

@ThomasBurleson
Copy link
Contributor

@smashercosmo - this appears to be an edge-case issue with $animate and ngMaterial. See Plunkr Demo and the script.js.

An has been reported to the Angular.JS team: $animate with ngShow is not working with Angular Material

@ThomasBurleson
Copy link
Contributor

Fixed with recent Angular.JS master build/snapshot: http://plnkr.co/edit/hQ2Q6y5Qi72fePI1VrUl?p=preview

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants