Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

md-autocomplete has a bug on demo site (in master version and 1.0.0rc2 #5448

Closed
tonyawad88 opened this issue Oct 30, 2015 · 12 comments
Closed
Assignees
Milestone

Comments

@tonyawad88
Copy link

Hello,

md-autocomplete has a bug on the demo site.
The steps to repeat:

  1. Left click on auto-complete box to open it
  2. Scroll to the very bottom
  3. Select "Wisconsin"
  4. Click on the "X" to clear the selction
  5. An Empty menu will show up with no items rendered.

screen shot 2015-10-29 at 9 49 53 pm

@tenshiAMD
Copy link

Hmm I tried this but it seems that the options are just hidden. Try to scroll again and the options will appear; thus this is still a bug and maybe its the md-virtual-repeat problem because it is resetting when deselecting the option.

@liveyourheart
Copy link

This happens on every md-virtual-repeat-container I've seen with over 8 items.. The repeat only renders the first 8 items (from the code, it looks like it expects 5 to fit and an extra 3), but does not reset the scroll. .

@kseamon
Copy link
Contributor

kseamon commented Nov 9, 2015

Pretty strange. The virtual repeat's scroller is reporting a scrollTop of 0, but the scrollbar is all the way at the bottom. That is why the repeater is rendering items at the top, out of view. Weird. Have not found a solution yet.

@kseamon
Copy link
Contributor

kseamon commented Nov 9, 2015

Also, it seems to not be a problem in FireFox.

@brenovieira
Copy link

@kseamon , indeed, I just saw this issue on Chrome.

But I tryed it now with 1.0.0.0-rc3 on Firefox and it seems there is another similar bug:

angular material issue 5448

It just shows the first 3 items instead of 5, like in chrome:

angular material issue 5448 1

If I scroll (or leave the input and enter again) the error continues.
now showing at codepen:

angular material issue 5448 2

@brenovieira
Copy link

Nops. I just saw in Chrome too after opening code pen:

angular material issue 5448 3

After scroll and leave and return to input the same:

angular material issue 5448 4

And this issue:

angular material issue 5448 5

angular material issue 5448 6

@kseamon
Copy link
Contributor

kseamon commented Nov 11, 2015

The rc3 bug is fixed by #5579.

@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc4, 1.0-rc5 Nov 16, 2015
@hillerstorm
Copy link

No... it's not

@kseamon kseamon modified the milestones: 1.0-rc6, 1.0-rc5 Nov 20, 2015
@kseamon
Copy link
Contributor

kseamon commented Nov 20, 2015

Are you still seeing the rc3 bug in rc4? I'm not. The original issue in this ticket remains unresolved (it's a doozy).

@kseamon
Copy link
Contributor

kseamon commented Nov 25, 2015

The other manifestation of the "rc3 bug" should be fixed by #5908.

@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc6, 1.0-rc8 Nov 25, 2015
@tonyawad88
Copy link
Author

Not sure if you guys are aware of this but also if you position your mouse cursor on the textbox and scroll, the suggestion list shifts down as per the screenshot below. Do you want me to open another issue for this ?

It occurs on Safari, Firefox and Chrome. I didn't test the other browsers but I am assuming it's the same on all.

screen shot 2015-11-29 at 4 09 15 pm

@gilad905
Copy link

The original bug (selecting an item from the bottom of the menu then clearing the selection) still reproduces on Firefox (48.0.2), as well as another, similar bug:
Opening the menu and quickly scrolling all the way to the bottom will render a few empty rows in the bottom of the menu.
While the list in material.angularjs.org/latest/demo/autocomplete has ~600 items, and so scrolling needs to be pretty fast for the bug to occur, I am working with a list of ~10,000 items, where even 'standard speed' scrolling will produce the bug.

This reproduces on Firefox (but not on Chrome) and with AM v1.1.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants