This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): improve handling of touch pads and touchscreens#11782
Merged
fix(autocomplete): improve handling of touch pads and touchscreens#11782
Conversation
- open options pop-up on `touchstart` - since a `click` is often not sent on touch devices - this usually happens when the start/end point are not the same - use `touchend` on the document to close the options panel on iOS - iOS mostly does not send `click` events for taps on the backdrop - call `doBlur()`` since iOS doesn't blur in this case - combine some jQuery event handler calls - combine duplicate `onMouseup()` and `focusInputElement()` functions - don't let touchstart or touchend events bubble out of the component - focus the input for `mousedown` events - this covers an edge case on touch pads where a `click` isn't sent - move `isIos` and `isAndroid` logic out of gestures into `$mdUtil` - add and correct JSDoc Fixes #11778. Relates to #11625. Relates to #11757. Relates to #11758.
82858b3 to
e731953
Compare
This was referenced Sep 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
md-autocompletecloses instantly or does not open when opened on touchscreens and touch pads.Issue Number:
Fixes #11778. Relates to #11625. Relates to #11757. Relates to #11758.
What is the new behavior?
touchstartclickis often not sent on touch devicestouchendon the document to close the options panel on iOSclickevents for taps on the backdroponMouseup()andfocusInputElement()functionstouchstartortouchendevents bubble out of the componentinputformousedowneventsclickisn't sentisIosandisAndroidlogic out of gestures into$mdUtilDoes this PR introduce a breaking change?
Other information
Tested on