Skip to content
This repository was archived by the owner on Mar 20, 2024. It is now read-only.

fix(typings): Fix Preboot Typings to accept multiple events. #108

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

josephliccini
Copy link
Contributor

  • The current behavior is that the "events" and "keycodes" property are allowed an array of one item.
  • The new behavior is that these properties now may have an array of any length.
  • Please check if the PR fulfills these requirements
  • What modules are related to this pull-request
  • server side
  • client side
  • inline
  • build process
  • docs
  • tests
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    remove unused proxy imports from some test files
    A TypeScript typings fix.

  • What is the current behavior? (You can also link to an open issue here)
    In the EventSelector interface, only arrays of one item are allowed for keyCodes and events.

  • What is the new behavior (if this is a feature change)?
    In the EventSelector interface, arrays of varying length are allowed for keyCodes and events.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

- The current behavior is that the "events" and "keycodes" property are allowed an array of one item.
- The new behavior is that these properties now may have an array of any length.
@josephliccini josephliccini force-pushed the joliccin/preboot-typings branch from 880b2b3 to 7aa5123 Compare September 26, 2019 20:56
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@CaerusKaru CaerusKaru merged commit f11c8ff into angular:master Sep 26, 2019
@josephliccini
Copy link
Contributor Author

@CaerusKaru thanks for merging!

When do you think this could be released to NPM?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants