Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Docs: distinguish between older and newer versions of angular for $bindings #1480

Closed
caitp opened this issue Oct 29, 2014 · 4 comments
Closed
Assignees
Milestone

Comments

@caitp
Copy link

caitp commented Oct 29, 2014

Legacy Angular would require methods like ProtractorBy#repeater#column("{{binding}}"). Now, the interpolation delimiters aren't included, and cause failures if they are included. I can't recall which version / sha this changed in, but it's probably a good idea to document it.

@juliemr
Copy link
Member

juliemr commented Oct 29, 2014

Absolutely. Maybe something in the Angular 1.3 migration guide?

@caitp
Copy link
Author

caitp commented Oct 29, 2014

I was thinking it would be more the api docs themselves, since those are what people tend to look for when they're new to a tool, rather than migration guides.

juliemr added a commit to juliemr/angular.js that referenced this issue Dec 9, 2014
There are a couple of changes to some Protractor tests that need to be made
when migrating from AngularJS 1.2 to 1.3 - document these in the migration
guide.

See angular/protractor#1480
@juliemr
Copy link
Member

juliemr commented Dec 9, 2014

Sorry for the delays here. Documented in Protractor's API docs, and linked a PR to update the migration docs for Angular 1.2 -> 1.3.

@juliemr juliemr self-assigned this Dec 9, 2014
@juliemr juliemr added this to the 1.6.0 milestone Dec 9, 2014
juliemr added a commit to juliemr/angular.js that referenced this issue Dec 9, 2014
There are a couple of changes to some Protractor tests that need to be made
when migrating from AngularJS 1.2 to 1.3 - document these in the migration
guide.

See angular/protractor#1480
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this issue Dec 12, 2014
There are a couple of changes to some Protractor tests that need to be made
when migrating from AngularJS 1.2 to 1.3 - document these in the migration
guide.

See angular/protractor#1480
juliemr added a commit to angular/angular.js that referenced this issue Dec 15, 2014
There are a couple of changes to some Protractor tests that need to be made
when migrating from AngularJS 1.2 to 1.3 - document these in the migration
guide.

See angular/protractor#1480

Closes #10377
@juliemr
Copy link
Member

juliemr commented Dec 16, 2014

Migration guide also updated!

@juliemr juliemr closed this as completed Dec 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants