Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

fix(driverProviders): Check config in the right place. #3991

Merged
heathkit merged 2 commits into from
Jan 20, 2017
Merged

fix(driverProviders): Check config in the right place. #3991

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bc1f09
fix(driverProviders): Check config in the right place.
heathkit Jan 20, 2017
7b0194a
Moving check again.
heathkit Jan 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lib/driverProviders/local.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,6 @@ export class Local extends DriverProvider {

let serverConf = this.config_.localSeleniumStandaloneOpts || {};

if (!Array.isArray(serverConf.jvmArgs)) {
throw new ConfigError(logger, 'jvmArgs should be an array.');
}

// If args or port is not set use seleniumArgs and seleniumPort
// for backward compatibility
if (serverConf.args === undefined) {
Expand All @@ -115,6 +111,9 @@ export class Local extends DriverProvider {
if (serverConf.port === undefined) {
serverConf.port = this.config_.seleniumPort;
}
if (!Array.isArray(serverConf.jvmArgs)) {
Copy link
Contributor

@sjelin sjelin Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be in an else block back on line 110

Copy link
Contributor Author

@heathkit heathkit Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, done.

throw new ConfigError(logger, 'jvmArgs should be an array.');
}

// configure server
if (this.config_.chromeDriver) {
Expand Down