Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

made dependent package versions explicit #187

Closed
wants to merge 2 commits into from
Closed

made dependent package versions explicit #187

wants to merge 2 commits into from

Conversation

psnider
Copy link

@psnider psnider commented Aug 18, 2016

I had trouble running the quickstart because of: #186

Both of these commands now work with a fresh git clone and npm install:

  • npm start
  • npm test

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@psnider
Copy link
Author

psnider commented Aug 18, 2016

I signed the CLA

@googlebot
Copy link

CLAs look good, thanks!

@wardbell
Copy link
Contributor

wardbell commented Sep 2, 2016

Thanks but your PR is pre-RC6 and we do not want to pin the npm versions as you propose.

@wardbell wardbell closed this Sep 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants