This repository was archived by the owner on Oct 14, 2024. It is now read-only.
build: Move reflect-metadata & express from devDependencies to dependencies #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue I ran into while proving out a production-ready environment for hosting a Universal app. I noticed some devDependencies modules are required to be installed in order to run the application, which should not be the case.
Changes in a nutshell: Moves express and reflect-metadata from devDependencies to run dependencies.
Steps to reproduce issue
npm install
npm run build:ssr
node_modules
npm install --production
to install run-time modulesnode dist/server
Following these steps, the node server will crash on launch due to missing dependencies: