We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When you add an input binding with an expression the component is then of type HTMLElement instead of FooComponent.
HTMLElement
FooComponent
Additional context
Angular Language Server: 11.2.10 Angular CLI: 12.0.0-next.8 Node: 12.18.0 OS: darwin x64
Angular: 12.0.0-next.8 ... animations, cli, common, compiler, compiler-cli, core, forms ... language-service, platform-browser, platform-browser-dynamic ... platform-server, router
@angular-devkit/architect 0.1200.0-next.8 @angular-devkit/build-angular 0.1200.0-next.8 @angular-devkit/core 12.0.0-next.8 @angular-devkit/schematics 12.0.0-next.8 @angular/cdk 12.0.0-next.6 @angular/fire 6.1.4 @angular/material 12.0.0-next.6 @nguniversal/builders 12.0.0-next.1 @nguniversal/express-engine 12.0.0-next.1 @schematics/angular 12.0.0-next.8 rxjs 6.6.6 typescript 4.2.3
The text was updated successfully, but these errors were encountered:
fix(language-service): bound attributes should not break directive ma…
ef7e4b4
…tching The language service uses an elements attributes to determine if it matches a directive in the component scope. We do this by accumulating all attribute bindings and matching against the selectors for the available directives. The compiler itself does a similar thing. In addition, the compiler does not use the value of `BoundAttribute`s to match directives (https://github.com/angular/angular/blob/cdf1ea1951fb7187b1f6c9bb8a847c859c41e0b8/packages/compiler/src/render3/view/util.ts#L174-L206). This commit changes the language service to also ignore bound attribute values for directive matching. Fixes angular/vscode-ng-language-service#1278
angular/angular@bd34bc9
3dbcc7f
…tching (#41597) The language service uses an elements attributes to determine if it matches a directive in the component scope. We do this by accumulating all attribute bindings and matching against the selectors for the available directives. The compiler itself does a similar thing. In addition, the compiler does not use the value of `BoundAttribute`s to match directives (https://github.com/angular/angular/blob/cdf1ea1951fb7187b1f6c9bb8a847c859c41e0b8/packages/compiler/src/render3/view/util.ts#L174-L206). This commit changes the language service to also ignore bound attribute values for directive matching. Fixes angular/vscode-ng-language-service#1278 PR Close #41597
This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.
Sorry, something went wrong.
atscott
No branches or pull requests
When you add an input binding with an expression the component is then of type
HTMLElement
instead ofFooComponent
.Additional context
Angular Language Server: 11.2.10
Angular CLI: 12.0.0-next.8
Node: 12.18.0
OS: darwin x64
Angular: 12.0.0-next.8
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router
Package Version
@angular-devkit/architect 0.1200.0-next.8
@angular-devkit/build-angular 0.1200.0-next.8
@angular-devkit/core 12.0.0-next.8
@angular-devkit/schematics 12.0.0-next.8
@angular/cdk 12.0.0-next.6
@angular/fire 6.1.4
@angular/material 12.0.0-next.6
@nguniversal/builders 12.0.0-next.1
@nguniversal/express-engine 12.0.0-next.1
@schematics/angular 12.0.0-next.8
rxjs 6.6.6
typescript 4.2.3
The text was updated successfully, but these errors were encountered: