Skip to content

Error in HTML not reported on file open #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mickaelistria opened this issue Sep 21, 2020 · 2 comments · Fixed by #966
Closed

Error in HTML not reported on file open #922

mickaelistria opened this issue Sep 21, 2020 · 2 comments · Fixed by #966
Assignees
Labels

Comments

@mickaelistria
Copy link
Contributor

Using @angular/language-server 0.1001.0 and @angular/language-service 10.1.1, I see a regression compared to @angular/language-server 0.1000.4.
To reproduce, with Eclipse WIld Web Developer

  1. open and provision (npm install) a simple project like https://github.com/eclipse/wildwebdeveloper/tree/master/org.eclipse.wildwebdeveloper.tests/testProjects/angular-app
  2. Open appComponentWithHtml.ts , let tsserver and angular-ls load (ie show outline or provide some Angular specific completion)
  3. Then open appConponentWithHtml.html
    EXPECTED: Error marker shows on incorrect template
    GOT: No error marker. Note that if I then make any change to the document, the expected error marker shows up.

With previous versions of @angular/language-server, this was working as expected, the marker/diagnostic was showing up on file open.

@mickaelistria
Copy link
Contributor Author

Actually, the issue doesn't come from migration to newer @angular/language-serv*, but from simultaneous migration from typescript 3.9.7 to typescript 4.0.2. If using typescript 3.9.7, all @angular/language-serv* versions mentioned earlier works perfectly; if using typescript 4.0.2, all @angular/language-serv* versions mentioned earlier fail at showing diagnostic on .html file opening (but do show it after edit).

@kyliau kyliau self-assigned this Nov 4, 2020
kyliau added a commit to kyliau/vscode-ng-language-service that referenced this issue Nov 9, 2020
This commit fixes a bug whereby existing diagnostics in an external template
are not shown when the file is opened the first time. Diagnostics only show
up when subsequent edits are made to the file.
This is a regression after upgrading to TS 4.0

Fix angular#922
kyliau added a commit that referenced this issue Nov 10, 2020
This commit fixes a bug whereby existing diagnostics in an external template
are not shown when the file is opened the first time. Diagnostics only show
up when subsequent edits are made to the file.
This is a regression after upgrading to TS 4.0

Fix #922
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants