-
Notifications
You must be signed in to change notification settings - Fork 123
Error in HTML not reported on file open #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Actually, the issue doesn't come from migration to newer @angular/language-serv*, but from simultaneous migration from typescript 3.9.7 to typescript 4.0.2. If using typescript 3.9.7, all @angular/language-serv* versions mentioned earlier works perfectly; if using typescript 4.0.2, all @angular/language-serv* versions mentioned earlier fail at showing diagnostic on .html file opening (but do show it after edit). |
This commit fixes a bug whereby existing diagnostics in an external template are not shown when the file is opened the first time. Diagnostics only show up when subsequent edits are made to the file. This is a regression after upgrading to TS 4.0 Fix angular#922
This commit fixes a bug whereby existing diagnostics in an external template are not shown when the file is opened the first time. Diagnostics only show up when subsequent edits are made to the file. This is a regression after upgrading to TS 4.0 Fix #922
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Using @angular/language-server 0.1001.0 and @angular/language-service 10.1.1, I see a regression compared to @angular/language-server 0.1000.4.
To reproduce, with Eclipse WIld Web Developer
npm install
) a simple project like https://github.com/eclipse/wildwebdeveloper/tree/master/org.eclipse.wildwebdeveloper.tests/testProjects/angular-appEXPECTED: Error marker shows on incorrect template
GOT: No error marker. Note that if I then make any change to the document, the expected error marker shows up.
With previous versions of @angular/language-server, this was working as expected, the marker/diagnostic was showing up on file open.
The text was updated successfully, but these errors were encountered: