Skip to content
This repository was archived by the owner on May 20, 2023. It is now read-only.

Components update #88

Merged
merged 3 commits into from
May 3, 2017
Merged

Components update #88

merged 3 commits into from
May 3, 2017

Conversation

nshahan
Copy link
Contributor

@nshahan nshahan commented May 2, 2017

  • Glyph: Add baseline attribute.
  • Material Expansionpanel:
    • Allow programmatic expand and collapse requests even if the panel is
      disabled.
    • Change preserveWhitespace default to false.
    • Add enterAccepts flag.
  • Material Input:
    • Show counter regardless of focus.
    • Add error message to MaterialPercentInputDirective.
  • Material List: Allow pointer events when disabled.
  • Material Popup: Fix positioning when matchMinSourceWidth is true.
  • Material Ripple: Show a centered ripple on keypress.
  • Material Select:
    • Only display underline when border is also set.
    • Add useCheckMarks to use check marks instead of checkboxes.
  • Material Tooltips: Resize to fit contents.
  • Material Yes/No Buttons: Add enterAccepts flag.
  • Deprecate LazyStreamController and migrate to StreamController.
  • Migrate use of LazyEventController to StreamController.
  • Documentation fixes.
  • Strong mode fixes.

nshahan added 2 commits May 2, 2017 11:26
 * Glyph: Add baseline attribute.
 * Material Expansionpanel:
   * Allow programmatic `expand` and `collapse` requests even if the panel is
     `disabled`.
   * Change `preserveWhitespace` default to false.
   * Add `enterAccepts` flag.
 * Material Input:
   * Show counter regardless of focus.
   * Add error message to `MaterialPercentInputDirective`.
 * Material List: Allow pointer events when disabled.
 * Material Popup: Fix positioning when `matchMinSourceWidth` is true.
 * Material Ripple: Show a centered ripple on keypress.
 * Material Select:
   * Only display underline when border is also set.
   * Add `useCheckMarks` to use check marks instead of checkboxes.
 * Material Tooltips: Resize to fit contents.
 * Material Yes/No Buttons: Add `enterAccepts` flag.
 * Deprecate LazyStreamController and migrate to StreamController.
 * Migrate use of LazyEventController to StreamController.
 * Documentation fixes.
 * Strong mode fixes.
@nshahan nshahan requested review from kevmoo and jakemac53 May 2, 2017 22:35
Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also: verified the examples still work?

pubspec.yaml Outdated
description: >
The official Material Design components for AngularDart. Used at Google
in production apps.
homepage: https://github.com/dart-lang/angular_components
author: Dart Team <[email protected]>
environment:
sdk: '>=1.23.0 <2.0.0'
sdk: '>=1.23.0-dev.11.11 <2.0.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops yeah. I added that in so I could build on my desktop. I will remove.

pubspec.yaml Outdated
@@ -1,12 +1,12 @@
name: angular_components
version: 0.5.0
version: 0.5.0+1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New features? No breaks? Should be 0.5.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@nshahan
Copy link
Contributor Author

nshahan commented May 3, 2017

Yes, I verified with the angular_components_example. I will make a small update there to demo the new checkmark option for material select and bump the dependency.

@nshahan nshahan merged commit 4518e63 into master May 3, 2017
@nshahan nshahan deleted the components_update branch May 3, 2017 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants